Info

In Clang 15, the detect_stack_use_after_return ASAN option was enabled by default. This option seems to make automatic storage duration objects not go on the stack. StackLocator assumes such objects are on the stack. See here - the object assumes this is on the stack and compares this to the bounds of the stack (which are determined in a platform-specific way) to estimate how much stack space remains. StackLocator also invokes UB by doing relational comparisons and subtractions on pointers that aren't from the same allocation. One possible fix is to use __builtin_frame_address(0) to get the frame pointer instead of using the address of a local variable. However, StackLocator is only used in one place in mozjs here - it controls the amount of stack space available to javascript. Maybe instead of trying to fix StackLocator, we could do something different here like setting the quota to 50% of all stack space? There's another minor test-only case here where we make the same assumption about an automatic storage duration variable being on the stack.

Top User Comments

xgen-internal-githook commented on Thu, 10 Apr 2025 03:36:57 +0000: Author: {'name': 'Ryan Berryhill', 'email': 'ryan.berryhill@mongodb.com', 'username': 'ryanberryhill'} Message: SERVER-100334 Fix StackLocator functionality broken by v5 toolchain ASAN (#34132) GitOrigin-RevId: 88bd5b2912d6fabd0ddd8ae366a6e693e5a988ab Branch: master https://github.com/mongodb/mongo/commit/d2fc0558f008d8a06c0dcbf62e4f9d6f1ff1e22a

Steps to Reproduce