Info

Environment: db version v3.1.1-pre- git version: 5e7aa5c9efdea28cc82ff8d0ea0e3a76cf5c94f8 OpenSSL version: OpenSSL 1.0.1m-fips 19 Mar 2015 Scenario: Low bit corruption with SSL enabled Problem: Memory allocated in here SSLConnection* sslConn = new SSLConnection(_serverContext, socket, initialBytes, len); Memory has not been released during the error handler _handleSSLError() consider replacing the sslconnection w/ auto release pointer * socket, const char* initialBytes, int len) { SSLConnection* sslConn = new SSLConnection(_serverContext, socket, initialBytes, len); ScopeGuard sslGuard = MakeGuard(::SSL_free, sslConn->ssl); ScopeGuard bioGuard = MakeGuard(::BIO_free, sslConn->networkBIO); int ret; do { ret = ::SSL_accept(sslConn->ssl); } while(!_doneWithSSLOp(sslConn, ret)); if (ret != 1) _handleSSLError(SSL_get_error(sslConn, ret), ret); sslGuard.Dismiss(); bioGuard.Dismiss();

Top User Comments

xgen-internal-githook commented on Mon, 13 Apr 2015 17:47:07 +0000: Author: {u'username': u'guoyr', u'name': u'Robert Guo', u'email': u'robert.guo@10gen.com'} Message: SERVER-17832 Fix Resource Leak on SSL Connect and Accept Exception Closes #949 Signed-off-by: Ramon Fernandez Branch: master https://github.com/mongodb/mongo/commit/0ffa0a1535e917d10ea48c9a8773188058106e55 xgen-internal-githook commented on Mon, 13 Apr 2015 17:34:18 +0000: Author: {u'username': u'guoyr', u'name': u'Robert Guo', u'email': u'robert.guo@10gen.com'} Message: SERVER-17832 Fix Resource Leak on SSL Connect and Accept Exception (v2.6, v3.0) Signed-off-by: Ramon Fernandez Branch: v2.6 https://github.com/mongodb/mongo/commit/beb4833ca9c6ce5b6ec528b4fe0ce5818f75905e xgen-internal-githook commented on Mon, 13 Apr 2015 17:33:39 +0000: Author: {u'username': u'guoyr', u'name': u'Robert Guo', u'email': u'robert.guo@10gen.com'} Message: SERVER-17832 Fix Resource Leak on SSL Connect and Accept Exception (v2.6, v3.0) Closes #950 Signed-off-by: Ramon Fernandez Branch: v3.0 https://github.com/mongodb/mongo/commit/8e808ee8b4a0f8838218f9b670e8a161784e96dc robert.guo commented on Mon, 13 Apr 2015 16:43:57 +0000: backport PR: https://github.com/mongodb/mongo/pull/950 robert.guo commented on Mon, 13 Apr 2015 15:33:56 +0000: PR: https://github.com/mongodb/mongo/pull/949

Steps to Reproduce