Info
router_transaction_metrics.js assumes for every commit type that if a commit was successful, the corresponding successfulDurationMicros metric will be greater than 0. The no shards commit type doesn't require any network messages so it's possible to complete in less than a microsecond, which fails this test.
To avoid failures, the test should relax this assertion for just the no shards commit type. The other commit types all require at least one network message, so it should be safe to keep this assumption for them.
Top User Comments
xgen-internal-githook commented on Wed, 10 Aug 2022 15:32:40 +0000:
Author:
{'name': 'Jonathan Lee', 'email': 'jonathan.lee@mongodb.com', 'username': 'jonatlee'}
Message: SERVER-55345 exclude noShards commit type from duration assertion in router_transaction_metrics.js
(cherry picked from commit 856e40338a080691f09986756529935683f86e47)
Branch: v4.2
https://github.com/mongodb/mongo/commit/d890505f7ec3a446393e77f1c270ccbaf0630c66
xgen-internal-githook commented on Thu, 9 Sep 2021 16:58:40 +0000:
Author:
{'name': 'Jonathan Lee', 'email': 'jonathan.lee@mongodb.com', 'username': 'jonatlee'}
Message: SERVER-55345 exclude noShards commit type from duration assertion in router_transaction_metrics.js
Branch: master
https://github.com/mongodb/mongo/commit/856e40338a080691f09986756529935683f86e47
