Info

When we introduced database versioning, one of the cases in isMetadataDifferent was logically reversed. This resulted in the batch exec retry loop thinking that every retry had changed targeting, which caused certain types of errors to be retried indefinitely instead of stopping at the default limit of "5 retries".

Top User Comments

xgen-internal-githook commented on Thu, 26 Dec 2019 14:47:03 +0000: Author: {'name': 'Esha Maharishi', 'email': 'esha.maharishi@mongodb.com', 'username': 'EshaMaharishi'} Message: SERVER-45292 fix isMetadataDifferent logic in chunk manager targeter Branch: master https://github.com/mongodb/mongo/commit/6e26f1ac12b37a61428c53ffc5276c18a1a32cfa milkie commented on Mon, 23 Dec 2019 21:14:11 +0000: My attempt at fixing this failed because fixing the logic in isMetadataDifferent broke some jstests that were expecting unsharded collections (like track_unsharded_collections_rename_collection.js)

Steps to Reproduce