Info

The following warning introduced by SERVER-22606 does not actually check that the problem filesystem is XFS - it checks that it is ext4: ** WARNING: Using the XFS filesystem is strongly recommended with the WiredTiger storage engine We should change this to check that fs_stats.f_type != XFS_SUPER_MAGIC instead of fs_stats.f_type == EXT4_SUPER_MAGIC.

Top User Comments

sallgeud commented on Sat, 3 Dec 2016 16:40:19 +0000: It's not the warning message. It's the if statement. The original bug and the other comments are absolutely clear on this point. Do you not recommend people use xfs over FAT or btrfs? If (NOT XFS) { Warning that you're not issuing xfs } is the logical setup. the problem is you need to ask if it's not xfs (as others have stated), instead of only complaining about ext. More specifically I can assure you btrfs and fat are even worse for performance than ext4. We tested extensively. milkie commented on Sat, 3 Dec 2016 16:29:25 +0000: The "if" statement is not illogical at all. If the file system for the dbpath is ext2, ext3, or ext4, the code displays a warning saying that xfs is recommended instead. chad@onspring.com sallgeud are you suggesting that we should recommend a different filesystem other than xfs in the warning message? I have already stated that users running other filesystems than ext2, ext3, or ext4, should not receive a warning. Personally, I believe the warning message is fine, as it clearly communicates what the administrator needs to do to clear the warning (but it could be made more explicit with Kevin's suggested wording). I don't see how the warning or the code has no purpose. sallgeud commented on Fri, 2 Dec 2016 22:25:13 +0000: Yes. The if statement is illogical relative to the message it generates. It's clearly a bug. While insignificant to functionality, it is almost entirely without purpose the way it's written. jonathan.reams@10gen.com commented on Fri, 2 Dec 2016 21:25:29 +0000: My point is that the error message is not connected to the check that triggers to it. We're telling you to use the XFS filesystem, but we check that you're using EXT4. milkie commented on Fri, 2 Dec 2016 21:22:59 +0000: I'm in favor of changing the message, but I don't understand the incentive to change the logic. If a user is electing to use a filesystem other than EXT* or XFS on Linux, they already have to be expecting that they are going to have a performance profile that might not be ideal. kevin.pulo@10gen.com commented on Wed, 30 Nov 2016 05:33:08 +0000: I also recommend we adjust the message a little to make it clearer what the actual problem is, eg: ** WARNING: The dbpath is not using the XFS filesystem. ** XFS is strongly recommended with the WiredTiger storage engine. ** See http://dochub.mongodb.org/core/prodnotes-filesystem

Steps to Reproduce