Issue

Description of problem: xfsdump/xfsrestore: suggest recovery for false roots may be possible using -x Description of problem: Some versions of xfsdump may produce archives that cannot be restored correctly problems with bind mounts identified in Bug 1698057, a fix to restore these archives was made in Bug 2034327. This fix uses a new option `-x` to allow archives to be restored, unfortunately for the case where an archive causes xfsrestore to fail with an assert there's no direction given to the user that recovery may be possible. Version-Release number of selected component (if applicable): xfsdump-3.1.10-1.el9.x86_64 Steps to Reproduce: Using the xfsdump attached to the bz mkdir /tmp/test xfsrestore -f bind_mount-xfsdump-3.1.4-1.el7.x86_64.dump /tmp/test Actual results: xfsrestore: using file dump (drive_simple) strategy xfsrestore: version 3.1.10 (dump format 3.0) - type ^C for status and control xfsrestore: searching media for dump xfsrestore: examining media file 0 xfsrestore: dump description: xfsrestore: hostname: rhel-7_2 xfsrestore: mount point: /mnt2 xfsrestore: volume: /dev/loop0 xfsrestore: session time: Sat Mar 12 11:36:41 2022 xfsrestore: level: 0 xfsrestore: session label: "bind mount" xfsrestore: media label: "test" xfsrestore: file system id: 9327a140-79c1-4c02-9478-7f699c562409 xfsrestore: session id: 7e3f9f99-928c-40fe-ae65-93ba72387b1e xfsrestore: media id: d486cf35-b15c-480c-885d-20d7fe755a7d xfsrestore: searching media for directory dump xfsrestore: reading directories xfsrestore: tree.c:757: tree_begindir: Assertion `ino != persp->p_rootino || hardh == persp->p_rooth' failed. Aborted (core dumped) Expected results: xfsrestore: ERROR: tree.c:791: tree_begindir: Assertion `ino != persp->p_rootino || hardh == persp->p_rooth` failed. xfsrestore: ERROR: False root detected. Recovery may be possible using the `-x` option Aborted Additional info: Upstream: https://lore.kernel.org/linux-xfs/20230824020704.1893521-1-ddouwsma@redhat.com

Release Notes

No. of Comments

Resolution

Done-Errata