Issue
What were you trying to do that didn't work?
When a leapp upgrade fails, a file is created
/root/tmp_leapp_py3/.leapp_upgrade_failed
Once present, any future attempts at leapp will fail in emergency mode. This is a point of contention for many customers. Usually at this point, they will increase severity, demand phone calls, or remote session to get the data we need. We join sessions only to find the issue is we need to delete a file for them to then find if there is another issue.
Expected results
If the intent is to prevent a reboot from defaulting back into leapp and trying the upgrade again, we should change the default grub entry back to the previous kernel, or just off the leapp upgrade entry.
If the intent is to force a re-run of leapp upgrade, then remove the grub entry entirely. Though this seems like a less tactical approach when many systems don't need to re-run the command, they just needed to fix one thing and the system is still in a good state to upgrade after changing that.
If a customer has hit an issue, where they can boot into r7 fix it and then try again, then it doesn't sound like a harmful issue if they were to run into it again and again. That would make it more clear to the customer what their issue is ie "everytime i run leapp i get the same error" is good because they know the error.
Changing the error takes away a lot of their confidence. "I had an error, I thought I fixed it, and now i have a new error. I need someone to go over this with me on a remote".
Actual results
https://access.redhat.com/solutions/5233741
[
2.733206] localhost systemd[1]: Starting System Upgrade...
[
2.735217] localhost upgrade[776]: starting upgrade hook
[
2.740845] localhost upgrade[776]: /bin/upgrade: line 19: /sysroot/var/tmp/system-upgrade.state: No such file or directory
[
2.748461] localhost upgrade[779]:
WARNING: locking_type (4) is deprecated, using --sysinit --readonly.
[
2.751800] localhost upgrade[779]:
Allowing activation with --readonly --sysinit.
[
2.753022] localhost upgrade[779]:
1 logical volume(s) in volume group "appvg" now active
[
2.753022] localhost upgrade[779]:
Allowing activation with --readonly --sysinit.
[
2.753807] localhost upgrade[779]:
11 logical volume(s) in volume group "systemvg" now active
[
2.776154] localhost upgrade[785]: Found file /sysroot/root/tmp_leapp_py3/.leapp_upgrade_failed
[
2.776154] localhost upgrade[785]: Error: Leapp previously failed and cannot continue, returning back to emergency shell
[
2.776154] localhost upgrade[785]: Please file a support case with /sysroot/var/log/leapp/leapp-upgrade.log attached
[
2.776154] localhost upgrade[785]: To rerun the upgrade upon exiting the dracut shell remove the /sysroot/root/tmp_leapp_py3/.leapp_upgrade_failed file
