...
BugZero found this defect 2704 days ago.
Fix the method signatures to accommodate API changes for timestamps. In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.h:42:0, from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34: src/mongo/db/storage/record_store.h:374:34: error: 'virtual mongo::StatusWith mongo::RecordStore::insertRecord(mongo::OperationContext*, const char*, int, mongo::Timestamp, bool)' was hidden [-Werror=overloaded-virtual] virtual StatusWith insertRecord(OperationContext* opCtx, ^ In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34:0: src/mongo/db/modules/rocksdb/src/rocks_record_store.h:139:38: error: by 'virtual mongo::StatusWith mongo::RocksRecordStore::insertRecord(mongo::OperationContext*, const char*, int, bool)' [-Werror=overloaded-virtual] virtual StatusWith insertRecord( OperationContext* opCtx, ^ In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.h:42:0, from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34: src/mongo/db/storage/record_store.h:408:20: error: 'virtual mongo::Status mongo::RecordStore::insertRecordsWithDocWriter(mongo::OperationContext*, const mongo::DocWriter* const*, const mongo::Timestamp*, size_t, mongo::RecordId*)' was hidden [-Werror=overloaded-virtual] virtual Status insertRecordsWithDocWriter(OperationContext* opCtx, ^ In file included from src/mongo/db/modules/rocksdb/src/rocks_record_store.cpp:34:0: src/mongo/db/modules/rocksdb/src/rocks_record_store.h:144:24: error: by 'virtual mongo::Status mongo::RocksRecordStore::insertRecordsWithDocWriter(mongo::OperationContext*, const mongo::DocWriter* const*, size_t, mongo::RecordId*)' [-Werror=overloaded-virtual] virtual Status insertRecordsWithDocWriter(OperationContext* opCtx, ^
daniel.gottlieb@10gen.com commented on Wed, 30 Aug 2017 13:30:50 +0000: https://github.com/mongodb-partners/mongo-rocks/commit/7f453075b53548697e33692b76ba2451f38e9630